Skip to content

deps: update substrate-sdk to version 1.7.0#977

Merged
xlc merged 8 commits intoopen-web3-stack:masterfrom
RomarQ:rq/update-polkadot-sdk-v1.7.0
Mar 4, 2024
Merged

deps: update substrate-sdk to version 1.7.0#977
xlc merged 8 commits intoopen-web3-stack:masterfrom
RomarQ:rq/update-polkadot-sdk-v1.7.0

Conversation

@RomarQ
Copy link
Copy Markdown
Contributor

@RomarQ RomarQ commented Feb 13, 2024 •
edited
Loading

Update polkadot-sdk to version 1.7.0

Includes many xcm changes, which were introduced in paritytech/polkadot-sdk#1230.

To reduce the amount of breaking changes I did not remove the multi prefix from extrinsics in the xtokens pallet:

`transfer_multiasset`: Transfer `MultiAsset` assets.
`transfer_multiasset_with_fee`: Transfer `MultiAsset` specifying the fee
`transfer_multicurrencies`: Transfer several currencies specifying the
`transfer_multiassets`: Transfer several `MultiAsset` specifying the item

I tested the changes against https://github.com/paritytech/polkadot-sdk/tree/release-polkadot-v1.7.0

@RomarQ
Copy link
Copy Markdown
Contributor Author

RomarQ commented Feb 13, 2024 •
edited
Loading

Updating dependencies in Cargo.dev.toml since the crates have been updated in crates.io.

@RomarQ
Copy link
Copy Markdown
Contributor Author

RomarQ commented Feb 13, 2024 •
edited
Loading

@xlc Could you have a look at the changes? Thank you in advance :)

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.50633% with 77 lines in your changes are missing coverage. Please review.

Project coverage is 85.25%. Comparing base (c7910d3) to head (68fdf4d).

Files Patch % Lines
xtokens/src/mock/para_relative_view.rs 30.30% 23 Missing ⚠️
xtokens/src/lib.rs 76.25% 19 Missing ⚠️
asset-registry/src/impls.rs 60.00% 10 Missing ⚠️
xtokens/src/mock/para_teleport.rs 0.00% 10 Missing ⚠️
asset-registry/src/mock/relay.rs 0.00% 3 Missing ⚠️
xtokens/src/mock/relay.rs 40.00% 3 Missing ⚠️
asset-registry/src/mock/mod.rs 92.85% 2 Missing ⚠️
unknown-tokens/src/lib.rs 75.00% 2 Missing ⚠️
xcm-support/src/lib.rs 71.42% 2 Missing ⚠️
asset-registry/src/mock/para.rs 93.33% 1 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #977      +/-   ##
==========================================
- Coverage   85.27%   85.25%   -0.02%     
==========================================
  Files          87       87              
  Lines       10395    10350      -45     
==========================================
- Hits         8864     8824      -40     
+ Misses       1531     1526       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomarQ RomarQ marked this pull request as ready for review February 14, 2024 06:39
xlc
xlc requested changes Feb 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@xlc xlc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to leave upgrade to XCM v4 on a separate PR and I prefer only upgrade to it when it is thoroughly tested (e.g. when it is used by system parachains on testnets). There were enough bugs on v3 upgrades and we shouldn't take lightly on upgrading to v4.

@RomarQ
Copy link
Copy Markdown
Contributor Author

RomarQ commented Feb 14, 2024 •
edited
Loading

I prefer to leave upgrade to XCM v4 on a separate PR and I prefer only upgrade to it when it is thoroughly tested (e.g. when it is used by system parachains on testnets). There were enough bugs on v3 upgrades and we shouldn't take lightly on upgrading to v4.

Not sure it will be possible to not upgrade to XCM v4 since xcm-executor uses xcm::latest, I will try to have something minimal with a converter between V4 and V3.

More info: paritytech/polkadot-sdk#3214

I think the only breaking change regarding the SCALE encoding is the AssetId since the Abstract variant has been removed.

@RomarQ RomarQ marked this pull request as draft February 14, 2024 10:07
@xlc
Copy link
Copy Markdown
Member

xlc commented Feb 14, 2024

I will say it will be a major regression in polkadot-sdk if we are forced to use xcm v4 and if that’s actually the case, we need polkadot-sdk to be patched first.

@xlc xlc marked this pull request as ready for review February 28, 2024 02:02
@xlc
Copy link
Copy Markdown
Member

xlc commented Feb 29, 2024

with paritytech/polkadot-sdk#3328 we won't get 100% compatibility between v4 types and v3 types

@xlc xlc requested review from wangjj9219 and zjb0807 February 29, 2024 03:01
@xlc xlc merged commit d26b0b1 into open-web3-stack:master Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xlc xlc xlc approved these changes

@zjb0807 zjb0807 zjb0807 approved these changes

@wangjj9219 wangjj9219 wangjj9219 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RomarQ @xlc @zjb0807 @wangjj9219